Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inbound email improvements (continued) #5263

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Inbound email improvements (continued) #5263

merged 1 commit into from
Nov 18, 2024

Conversation

vadimkerr
Copy link
Member

follow up to #5259:

  • Auto confirm SNS subsriptions for ESP amazon_ses_validated
  • Add a couple of tests for SNS message validation (try with wrong SNS topic ARN, try with wrong singature)

@vadimkerr vadimkerr added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Nov 18, 2024
vadimkerr
vadimkerr commented Nov 18, 2024
View reviewed changes
engine/apps/email/inbound.py
@@ -26,12 +27,14 @@ class AmazonSESValidatedInboundWebhookView(amazon_ses.AmazonSESInboundWebhookVie

def validate_request(self, request):
"""Add SNS message validation to Amazon SES inbound webhook view, which is not implemented in Anymail."""

super().validate_request(request)
Copy link
Member Author

@vadimkerr vadimkerr Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call to super().validate_request is unnecessary here because django-anymail collects these validate_request methods from the whole superclass chain and runs them all in run_validators: https://github.com/anymail/django-anymail/blob/35383c7140289e82b39ada5980077898aa07d18d/anymail/webhooks/base.py#L28

@vadimkerr vadimkerr marked this pull request as ready for review November 18, 2024 11:41
@vadimkerr vadimkerr requested a review from a team as a code owner November 18, 2024 11:41
@vadimkerr vadimkerr added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit 5fbc3d0 Nov 18, 2024
29 checks passed
@vadimkerr vadimkerr deleted the vadimkerr/amazon-ses-validated-auto-confirm branch November 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadimkerr @matiasb